Change in osmo-e1d[master]: VTY interface support

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

tnt gerrit-no-reply at lists.osmocom.org
Mon Jun 29 13:53:17 UTC 2020


tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19036 )

Change subject: VTY interface support
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

https://gerrit.osmocom.org/c/osmo-e1d/+/19036/1/src/e1d.h 
File src/e1d.h:

https://gerrit.osmocom.org/c/osmo-e1d/+/19036/1/src/e1d.h@85 
PS1, Line 85: _e1d_find_intf(struct e1_daemon *e1d, uint8_t id);
Again, remove _ prefix..


https://gerrit.osmocom.org/c/osmo-e1d/+/19036/1/src/osmo-e1d.c 
File src/osmo-e1d.c:

https://gerrit.osmocom.org/c/osmo-e1d/+/19036/1/src/osmo-e1d.c@54 
PS1, Line 54: static const char *config_file = "osmo-e1d.cfg";
g_ prefix for consistency.


https://gerrit.osmocom.org/c/osmo-e1d/+/19036/1/src/osmo-e1d.c@86 
PS1, Line 86: 	"License AGPLv3+: GNU AGPL version 3 or later <http://gnu.org/licenses/agpl-3.0.html>\r\n"
Huh this is not AGPL.


https://gerrit.osmocom.org/c/osmo-e1d/+/19036/1/src/osmo-e1d.c@189 
PS1, Line 189: 		exit(1);
Using 'return' for one error and 'exit' for the other is weird. Pick one :)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/19036
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: I47b6e4efaad52e68e2b50a7993076f3706f86628
Gerrit-Change-Number: 19036
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Assignee: tnt <tnt at 246tNt.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 29 Jun 2020 13:53:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200629/b818d3f3/attachment.htm>


More information about the gerrit-log mailing list