This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
tnt gerrit-no-reply at lists.osmocom.orgtnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/19033 ) Change subject: remove code not specific to USB from usb.c to intf_line.c ...................................................................... Patch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/c/osmo-e1d/+/19033/1/src/e1d.h File src/e1d.h: https://gerrit.osmocom.org/c/osmo-e1d/+/19033/1/src/e1d.h@85 PS1, Line 85: _e1_intf_new(struct e1_daemon *e1d, void *drv_data); I would remove the _ (underscore) prefix, which I try to keep for internal / static helpers to the file and not for exposed functions. https://gerrit.osmocom.org/c/osmo-e1d/+/19033/1/src/e1d.h@91 PS1, Line 91: _e1_rx_hdlcfs(struct e1_ts *ts, uint8_t *buf, int len); I think e1_ts_xxx would fit the naming scheme better if this becomes some sort of internal API. (i.e. e1_ts_rx_hdlcfs(...) ) Same for TX obviously. -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/19033 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I7d4d4ab39cb3e7e6a7eb8e738a367122eb3fbee2 Gerrit-Change-Number: 19033 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Assignee: tnt <tnt at 246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Reviewer: tnt <tnt at 246tNt.com> Gerrit-Comment-Date: Mon, 29 Jun 2020 12:45:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200629/51231c62/attachment.htm>