Change in osmo-pcu[master]: gprs_ms: Transfer known EGPRS MS class when mergling old MS

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Jun 26 16:12:33 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/19022 )

Change subject: gprs_ms: Transfer known EGPRS MS class when mergling old MS
......................................................................

gprs_ms: Transfer known EGPRS MS class when mergling old MS

Since not all the the information about the MS is known during TBF
creation in all scenrios, it may happen that when TBF is created it
creates a MS which later will end up being found a duplicate of an
already previously existing MS.
At that point, the old object is dropped and information retrieved from
both is merged into the new one.

The GPRS MS class was being transferred, but the EGPRS MS class was missing.

Change-Id: Ieb9929b60254b12f79392d6acb8b456d71cccb9e
---
M src/gprs_ms.cpp
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved
  laforge: Looks good to me, approved



diff --git a/src/gprs_ms.cpp b/src/gprs_ms.cpp
index 341826c..494ed2e 100644
--- a/src/gprs_ms.cpp
+++ b/src/gprs_ms.cpp
@@ -386,6 +386,9 @@
 	if (!ms_class() && old_ms->ms_class())
 		set_ms_class(old_ms->ms_class());
 
+	if (!egprs_ms_class() && old_ms->egprs_ms_class())
+		set_egprs_ms_class(old_ms->egprs_ms_class());
+
 	m_llc_queue.move_and_merge(&old_ms->m_llc_queue);
 
 	old_ms->reset();

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19022
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ieb9929b60254b12f79392d6acb8b456d71cccb9e
Gerrit-Change-Number: 19022
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200626/8ca6e176/attachment.htm>


More information about the gerrit-log mailing list