Change in osmo-msc[master]: propagate Compl L3 Info Cell ID to the VLR subscriber record

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Jun 25 19:53:11 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/18997 )

Change subject: propagate Compl L3 Info Cell ID to the VLR subscriber record
......................................................................

propagate Compl L3 Info Cell ID to the VLR subscriber record

As soon as the subscriber is authenticated, update the VLR entry with the
MSC-A's full CGI, including the Cell Id received from the Complete Layer 3
Information.

Thus the Cell Id will be shown by vty 'show subscriber cache' and 'show
connection'.

This is tested by osmo-ttcn3-hacks Ie410714a96353f74a52a104c56fa0a08683e0004.

Related: OS#4627
Change-Id: Iee1781985fb25b21ce27526c6a3768bf70d4dc9a
---
M src/libmsc/msc_a.c
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/libmsc/msc_a.c b/src/libmsc/msc_a.c
index fd66ad3..76c0f01 100644
--- a/src/libmsc/msc_a.c
+++ b/src/libmsc/msc_a.c
@@ -138,6 +138,12 @@
 
 	update_counters(fi, conn_accepted);
 
+	if (conn_accepted) {
+		/* Record the Cell ID seen in Complete Layer 3 Information in the VLR, so that it also shows in vty
+		 * 'show' output. */
+		vsub->cgi = msc_a->via_cell;
+	}
+
 	/* Trigger transactions that we paged for */
 	if (msc_a->complete_layer3_type == COMPLETE_LAYER3_PAGING_RESP) {
 		if (conn_accepted)

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/18997
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Iee1781985fb25b21ce27526c6a3768bf70d4dc9a
Gerrit-Change-Number: 18997
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200625/0d29fec1/attachment.htm>


More information about the gerrit-log mailing list