Change in osmo-ci[master]: ansible/gsm-tester: Install patchelf 0.11 on PATH

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Jun 25 18:24:33 UTC 2020


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/19015 )

Change subject: ansible/gsm-tester: Install patchelf 0.11 on PATH
......................................................................

ansible/gsm-tester: Install patchelf 0.11 on PATH

We used to install patchelf 0.10 in a specific path to only use it for
some binaries which had bugs with patchelf 0.9 (and other binaries had
bugs with 0.10, so we couldn't use 0.10 for all binaries and hence put
it in binary).

However, 0.11 is fixing both issues so we can use it in all cases, hence
we can put it in PATH (/usr/local/bin).

Related: OS#4389
Change-Id: Ica30807ecab7b60daee31fe7824b7c848d20c904
---
M ansible/roles/gsm-tester/tasks/main.yml
1 file changed, 8 insertions(+), 8 deletions(-)

Approvals:
  pespin: Looks good to me, approved; Verified



diff --git a/ansible/roles/gsm-tester/tasks/main.yml b/ansible/roles/gsm-tester/tasks/main.yml
index 7f0bad1..a3765b5 100644
--- a/ansible/roles/gsm-tester/tasks/main.yml
+++ b/ansible/roles/gsm-tester/tasks/main.yml
@@ -180,28 +180,28 @@
     - osmo-gsm-tester-proc
 
 # patchelf 0.9 available in debian has bugs with certain binaries. Version 0.10
-# fails on other binaries, so we need both 0.9 and 0.10 versions installed.
-- name: setup patchelf v0.10 repository
+# fails on other binaries, so we need version 0.11 installed in /usr/local/bin
+# (takes preference in PATH)
+- name: setup patchelf v0.11 repository
   git:
     repo: 'https://github.com/NixOS/patchelf.git'
     dest: /root/patchelf
-    version: "0.10"
+    version: "0.11"
     clone: yes
     update: no
   tags:
     - patchelf
     - osmo-gsm-tester-proc
 
-- name: build patchelf v0.10
+- name: build patchelf v0.11
   shell: |
       autoreconf -fi && \
-      ./configure --prefix=/opt && \
+      ./configure --prefix=/usr/local && \
       make && \
-      mkdir -p /opt/bin/ && \
-      cp src/patchelf /opt/bin/patchelf-v0.10
+      make install
   args:
     chdir: /root/patchelf
-    creates: /opt/bin/patchelf-v0.10
+    creates: /usr/local/bin/patchelf
   tags:
     - patchelf
     - osmo-gsm-tester-proc

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/19015
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ica30807ecab7b60daee31fe7824b7c848d20c904
Gerrit-Change-Number: 19015
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200625/39857926/attachment.htm>


More information about the gerrit-log mailing list