This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18986 ) Change subject: {ms,enb}_srs: add method to read kpi from a test run ...................................................................... Patch Set 1: (7 comments) https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18986/1/src/osmo_gsm_tester/obj/srslte_common.py File src/osmo_gsm_tester/obj/srslte_common.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18986/1/src/osmo_gsm_tester/obj/srslte_common.py@5 PS1, Line 5: # Author: Pau Espin Pedrol <pespin at sysmocom.de> I'm not the author ;) https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18986/1/src/osmo_gsm_tester/obj/srslte_common.py@20 PS1, Line 20: class srslte_common(): inherit from log.Origin https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18986/1/src/osmo_gsm_tester/obj/srslte_common.py@26 PS1, Line 26: from kpi_analyzer import kpi_analyzer So this kpi_analyzer is out of tree? What does it do exactly? can't it be mainlained? Please document so in the code. https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18986/1/src/osmo_gsm_tester/obj/srslte_common.py@28 PS1, Line 28: if self.log_file is not None: add self.log_file = None to the constructor, this way it's easy to see which fields are expected to be set by subclasses. https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18986/1/src/osmo_gsm_tester/obj/srslte_common.py@29 PS1, Line 29: kpis["log_" + self.name()] = analyzer.get_kpi_from_logfile(self.log_file) if you use self.name(), you definetly want to inherit from log.Origin here. https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18986/1/src/osmo_gsm_tester/obj/srslte_common.py@30 PS1, Line 30: if self.process.get_output_file('stdout') is not None: self.process = None in constructor https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18986/1/src/osmo_gsm_tester/obj/srslte_common.py@35 PS1, Line 35: print("Can't load KPI analyzer module.") self.log() (or self.err()) -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18986 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I28226a375f9ac4e08424c488062ae6a74a19af92 Gerrit-Change-Number: 18986 Gerrit-PatchSet: 1 Gerrit-Owner: srs_andre <andre at softwareradiosystems.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 25 Jun 2020 11:26:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200625/244af40b/attachment.htm>