Change in osmo-ttcn3-hacks[master]: bts: Introduce test TC_tx_power_start_ramp_down_bcch

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Tue Jun 23 20:55:16 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18980 )

Change subject: bts: Introduce test TC_tx_power_start_ramp_down_bcch
......................................................................


Patch Set 2: Code-Review+1

(5 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18980/2/bts/BTS_Tests.ttcn 
File bts/BTS_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18980/2/bts/BTS_Tests.ttcn@380 
PS2, Line 380: f_connhdlr_init_vty_bsc
Hmm, a separate VTY connection for ConnHdlr is the easiest way, but maybe you can just re-map the port somehow, like we do for the TRXC port?


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18980/2/bts/BTS_Tests.ttcn@2037 
PS2, Line 2037: function
Please make it private, here or in a separate change.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18980/2/bts/BTS_Tests.ttcn@2062 
PS2, Line 2062: f_verify_ramp_up
Same here, it should be private.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18980/2/bts/BTS_Tests.ttcn@2124 
PS2, Line 2124: function
private


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18980/2/bts/BTS_Tests.ttcn@2191 
PS2, Line 2191: function
private



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18980
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I895d69394a0123ae32b336c9ffaff615ba657f12
Gerrit-Change-Number: 18980
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Tue, 23 Jun 2020 20:55:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200623/2a0d2d9e/attachment.htm>


More information about the gerrit-log mailing list