Change in osmo-bts[master]: bts-virtual: Implement bts_model_trx_close

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue Jun 23 14:18:43 UTC 2020


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18955 )

Change subject: bts-virtual: Implement bts_model_trx_close
......................................................................

bts-virtual: Implement bts_model_trx_close

Change-Id: Id37562652b1ebc27d808d83342e4961b936dbcad
---
M src/osmo-bts-virtual/bts_model.c
1 file changed, 10 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved
  neels: Looks good to me, but someone else must approve
  laforge: Looks good to me, but someone else must approve



diff --git a/src/osmo-bts-virtual/bts_model.c b/src/osmo-bts-virtual/bts_model.c
index 8db0201..8209ce2 100644
--- a/src/osmo-bts-virtual/bts_model.c
+++ b/src/osmo-bts-virtual/bts_model.c
@@ -35,6 +35,8 @@
 #include <osmo-bts/handover.h>
 #include <osmo-bts/l1sap.h>
 
+#include "virtual_um.h"
+
 /* TODO: check if dummy method is sufficient, else implement */
 int bts_model_lchan_deactivate(struct gsm_lchan *lchan)
 {
@@ -52,7 +54,14 @@
 
 void bts_model_trx_close(struct gsm_bts_trx *trx)
 {
-	LOGP(DL1C, LOGL_NOTICE, "Unimplemented %s\n", __func__);
+	struct phy_instance *pinst = trx_phy_instance(trx);
+	struct phy_link *plink = pinst->phy_link;
+
+	if (phy_link_state_get(plink) != PHY_LINK_SHUTDOWN) {
+		virt_um_destroy(plink->u.virt.virt_um);
+		plink->u.virt.virt_um = NULL;
+		phy_link_state_set(plink, PHY_LINK_SHUTDOWN);
+	}
 	bts_model_trx_close_cb(trx, 0);
 }
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18955
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id37562652b1ebc27d808d83342e4961b936dbcad
Gerrit-Change-Number: 18955
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200623/64df0f9c/attachment.htm>


More information about the gerrit-log mailing list