Change in osmo-mgw[master]: manuals: generate vty reference xml at build time

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Tue Jun 23 12:57:36 UTC 2020


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18927 )

Change subject: manuals: generate vty reference xml at build time
......................................................................


Patch Set 3:

> Patch Set 3:
> 
> I guess this means that in any kind of cross compilation environment we don't get manuals anymore?  How do we handle this gracefully?

osmo-bsc.git already has this patch applied, so if this needs a change, osmo-bsc will need the same change.

I assumed the primary source of the vty reference is the build job for http://ftp.osmocom.org/docs/latest/

Another way to guarantee up-to-date-ness *and* presence of vty reference is to always keep a copy in the source tree. The gerrit build job could then regenerate and fail if there is a difference. That way a vty ref is always present.

One aspect there is that limited builds (e.g. the --disable-iu build in osmo-msc) produce a reduced vty reference that doesn't match the full one saved in the source tree. The gerrit verification job would have to make sure to only check the vty reference in the maximally featured build. possible.

I thought it would be more convenient and less spent time overall to not have to update the vty reference in the source tree and just accept that we don't build a reference during cross compilation. If we're willing to spend more time (now and in the future) then we could keep a copy in the source, too, and reject mismatching vty reference in gerrit.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18927
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I526af21134087e2b43b9ada59c93f636ae242e24
Gerrit-Change-Number: 18927
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Tue, 23 Jun 2020 12:57:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200623/95b5cfc8/attachment.htm>


More information about the gerrit-log mailing list