Change in libosmocore[master]: fixup for gsm0808_create_common_id(): add API doc, use new MI API

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Tue Jun 23 12:44:39 UTC 2020


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18966 )

Change subject: fixup for gsm0808_create_common_id(): add API doc, use new MI API
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/18966/1/src/gsm/gsm0808.c 
File src/gsm/gsm0808.c:

https://gerrit.osmocom.org/c/libosmocore/+/18966/1/src/gsm/gsm0808.c@1269 
PS1, Line 1269: 	*out = rc;
> well, I was using the same functions as used a few lines above when generating the GSM0808_IE_IMSI f […]
I did that and it caused test fallout, so we had to revert it...
(because in numerous tests we use erratic MI coding)

my angle is that we should use the new implementation in newly added functions, where there it is guaranteed to be no test fallout because we're not changing old behavior



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18966
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I979bca0c6aaa8fe4feddda922bd2e6c1cb49585b
Gerrit-Change-Number: 18966
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 23 Jun 2020 12:44:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200623/7224f612/attachment.htm>


More information about the gerrit-log mailing list