This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18904 ) Change subject: Implement tx power ramp down during BTS shutdown ...................................................................... Patch Set 4: Code-Review+1 (4 comments) https://gerrit.osmocom.org/c/osmo-bts/+/18904/4/src/common/bts_shutdown_fsm.c File src/common/bts_shutdown_fsm.c: https://gerrit.osmocom.org/c/osmo-bts/+/18904/4/src/common/bts_shutdown_fsm.c@51 PS4, Line 51: osmo_fsm_inst_dispatch I guess sending events to the FSM could be done directly, without the need to pass a callback function. Or will there be other call-backs in the upcoming changes? Not a merge blocker, just wondering. https://gerrit.osmocom.org/c/osmo-bts/+/18904/4/src/common/bts_shutdown_fsm.c@59 PS4, Line 59: for (i = 0; i < bts->num_trx; i++) { Why not to iterate over the linked list directly? llist_for_each_entry(trx, &bts->trx_list, list) { ... } gsm_bts_trx_num() does the same, but the larger the list of transceivers is, the more redundant iterations you do. https://gerrit.osmocom.org/c/osmo-bts/+/18904/4/src/common/bts_shutdown_fsm.c@75 PS4, Line 75: for (i = 0; i < bts->num_trx; i++) { Same here. Of course, this is not a performance critical part, but still. https://gerrit.osmocom.org/c/osmo-bts/+/18904/4/src/common/bts_shutdown_fsm.c@81 PS4, Line 81: %d %u, it's unsigned -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18904 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I70e34dda8974ebd94aea33bd9fb1d99f9063cc55 Gerrit-Change-Number: 18904 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: neels <nhofmeyr at sysmocom.de> Gerrit-Comment-Date: Tue, 23 Jun 2020 12:08:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200623/dad192db/attachment.htm>