This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
daniel gerrit-no-reply at lists.osmocom.orgdaniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18907 ) Change subject: fix crashes due to OSMO_ASSERT(conn->lchan) ...................................................................... Patch Set 5: (2 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/18907/5/src/osmo-bsc/gsm_data.c File src/osmo-bsc/gsm_data.c: https://gerrit.osmocom.org/c/osmo-bsc/+/18907/5/src/osmo-bsc/gsm_data.c@1724 PS5, Line 1724: if (bts && conn->lchan) > This one would be easily fixed by moving the bts = conn-get_bts() under this check. But we still need the check since we dereference bts->ms_max_power in the next line, so what do we gain? https://gerrit.osmocom.org/c/osmo-bsc/+/18907/5/src/osmo-bsc/osmo_bsc_bssap.c File src/osmo-bsc/osmo_bsc_bssap.c: https://gerrit.osmocom.org/c/osmo-bsc/+/18907/5/src/osmo-bsc/osmo_bsc_bssap.c@477 PS5, Line 477: static int bssmap_handle_cipher_mode(struct gsm_subscriber_connection *conn, > Changes in this function look like a different patch to me. I think it belongs in this patch, but I don't think we should use global variables (like bsc_gsmnet) if we can avoid it. So we still need to check if conn_get_bts() != NULL below. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18907 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id681dfb0ad654bdb4b71805d1ad4f39a8bf6bbd1 Gerrit-Change-Number: 18907 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Assignee: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-CC: daniel <dwillmann at sysmocom.de> Gerrit-CC: neels <nhofmeyr at sysmocom.de> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 23 Jun 2020 09:10:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200623/299202bf/attachment.htm>