Change in libosmocore[master]: gsm0808: Add gsm0808_create_common_id()

[neels]

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18946 )

Change subject: gsm0808: Add gsm0808_create_common_id()
......................................................................


Patch Set 2:

(1 comment)

that was quick to self+2, here is still review

https://gerrit.osmocom.org/c/libosmocore/+/18946/2/src/gsm/gsm0808.c 
File src/gsm/gsm0808.c:

https://gerrit.osmocom.org/c/libosmocore/+/18946/2/src/gsm/gsm0808.c@1256 
PS2, Line 1256: 	msgb_tlv_put(msg, GSM0808_IE_IMSI, mid_len - 2, mid_buf + 2);
this lacks error checking.
I would prefer using the new API:

  struct osmo_mobile_identity mi = { .type = GSM_MI_TYPE_IMSI };
  OSMO_STRLCPY_ARRAY(mi.imsi, imsi);
  uint8_t *l = msgb_tl_put(msg, GSM48_IE_MOBILE_ID);
  int rc = osmo_mobile_identity_encode_msgb(msg, &mi, false);
  if (rc < 0)
          goto error;
  *l = rc;

That looks a bit bloaty, maybe we can reconsider osmo_mobile_identity before the next release?



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18946
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I353adc1aa72377f7d4b3336d2ff47791fb73d62c
Gerrit-Change-Number: 18946
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Mon, 22 Jun 2020 15:43:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200622/3037f161/attachment.htm>