Change in osmo-trx[master]: Transceiver: Allow sending negative nominal tx power in RSP NOMTXPOWER

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Jun 22 10:11:58 UTC 2020


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/18914 )

Change subject: Transceiver: Allow sending negative nominal tx power in RSP NOMTXPOWER
......................................................................

Transceiver: Allow sending negative nominal tx power in RSP NOMTXPOWER

Some SDR devices under some bands may provide only under 0 dBm Tx Power.

Change-Id: I8cecb7a37eb80db341a624eb7b826180eac4a1d4
---
M Transceiver52M/Transceiver.cpp
1 file changed, 1 insertion(+), 4 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp
index 0b7ac31..7a81b7b 100644
--- a/Transceiver52M/Transceiver.cpp
+++ b/Transceiver52M/Transceiver.cpp
@@ -904,10 +904,7 @@
     sprintf(response, "RSP ADJPOWER 0 %d", power);
 } else if (match_cmd(command, "NOMTXPOWER", NULL)) {
     int power = mRadioInterface->getNominalTxPower(chan);
-    if (power > 0)
-      sprintf(response, "RSP NOMTXPOWER 0 %d", power);
-    else
-      sprintf(response, "RSP NOMTXPOWER 1 %d", -power);
+    sprintf(response, "RSP NOMTXPOWER 0 %d", power);
   } else if (match_cmd(command, "RXTUNE", &params)) {
     // tune receiver
     int freqKhz;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/18914
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I8cecb7a37eb80db341a624eb7b826180eac4a1d4
Gerrit-Change-Number: 18914
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200622/b82172d2/attachment.htm>


More information about the gerrit-log mailing list