Change in osmo-mgw[master]: refactor: use msgb to receive, pass and send RTP packets

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Jun 22 09:42:28 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18913 )

Change subject: refactor: use msgb to receive, pass and send RTP packets
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-mgw/+/18913/1/src/libosmo-mgcp/mgcp_network.c 
File src/libosmo-mgcp/mgcp_network.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/18913/1/src/libosmo-mgcp/mgcp_network.c@1310 
PS1, Line 1310: 	LOG_CONN_RTP(conn_src, LOGL_DEBUG, "msg ctx: %d %p %s\n",
> doesn't the logging system ensure the actual printf never happens unless soembody enabled this log c […]
Indeed good point, I was unsure whether the string was generated nevertheless of logging level but now I see it's like you say.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18913
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I3af40b63bc49f8636d4e7ea2f8f83bb67f6619ee
Gerrit-Change-Number: 18913
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 22 Jun 2020 09:42:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200622/02d0e106/attachment.htm>


More information about the gerrit-log mailing list