This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18948 ) Change subject: MSC_ConnectionHandler: fix race condition in f_establish_fully() ...................................................................... MSC_ConnectionHandler: fix race condition in f_establish_fully() For more details, see I25e10e28de174337233e6a3bb32cc16f2d7d614e. Change-Id: Icdb4f2e0edc4cb6e2010a9299331e7e93d0ca007 Related: OS#4619 --- M bsc/MSC_ConnectionHandler.ttcn 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn index 8ac7051..0d4c81b 100644 --- a/bsc/MSC_ConnectionHandler.ttcn +++ b/bsc/MSC_ConnectionHandler.ttcn @@ -801,6 +801,9 @@ /* register our component for this channel number at the RSL Emulation */ f_rslem_register(0, new_chan_nr); + /* dispatch queued messages for this channel (if any) */ + f_rslem_dchan_queue_dispatch(); + var PDU_ML3_MS_NW l3_tx := valueof(ts_RRM_AssignmentComplete('00'O)); /* send assignment complete over the new channel */ RSL.send(ts_RSL_EST_IND(new_chan_nr, valueof(ts_RslLinkID_DCCH(0)), @@ -1093,6 +1096,15 @@ g_media.mgcp_conn[1].mdcx_seen_exp := 0; } + /* On receipt of the BSSAP Assignment Command, the IUT (osmo-bsc) will allocate + * a channel and send us RR Assignment Command together with ip.access CRCX. + * There is a risk that the RSL Emulation component would dequeue and process + * ip.access CRCX faster than we process the Assignment Command and register + * the corresponding handler for the indicated RSL channel number. This would + * result in a failure, because at that moment there will be no handler for + * ip.access CRCX. Let's guard against this and enable additional queueing. */ + f_rslem_dchan_queue_enable(); + f_create_mgcp_expect(mgcpcrit); BSSAP.send(ass_cmd); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18948 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icdb4f2e0edc4cb6e2010a9299331e7e93d0ca007 Gerrit-Change-Number: 18948 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200621/073d2729/attachment.htm>