Change in osmo-bsc[master]: [cosmetic] system_information: Values are not guesses; more comments

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18935 )

Change subject: [cosmetic] system_information: Values are not guesses; more comments
......................................................................

[cosmetic] system_information: Values are not guesses; more comments

Change-Id: I978fbcd0c82658444b7603b082c236d23b0fa04b
---
M src/osmo-bsc/system_information.c
1 file changed, 2 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved



diff --git a/src/osmo-bsc/system_information.c b/src/osmo-bsc/system_information.c
index d5be3f2..de01112 100644
--- a/src/osmo-bsc/system_information.c
+++ b/src/osmo-bsc/system_information.c
@@ -1152,9 +1152,8 @@
 		.ctrl_ack_type_use_block = true,
 		.ext_info_present = 0,
 		.ext_info = {
-			/* The values below are just guesses ! */
-			.egprs_supported = 0,
-			.use_egprs_p_ch_req = 0,
+			.egprs_supported = 0,		/* overridden in gsm_generate_si() */
+			.use_egprs_p_ch_req = 0,	/* overridden in generate_si13() */
 			.bep_period = 5,
 			.pfc_supported = 0,
 			.dtm_supported = 0,

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18935
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I978fbcd0c82658444b7603b082c236d23b0fa04b
Gerrit-Change-Number: 18935
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200621/b7a9e62d/attachment.htm>