Change in osmo-ttcn3-hacks[master]: library/RSL_Emulation: implement waiting queue for DCHAN messages

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Jun 19 20:12:13 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18923 )

Change subject: library/RSL_Emulation: implement waiting queue for DCHAN messages
......................................................................


Patch Set 1:

I don't really like the idea of silently queueing messages somewhere.  This has the potential of hiding bugs, as the IUT can now send masssive amounts of unexpected/wrong messages which will just be stuffed into a queue somewhere rather than making the test case fail.

I don't really have a good alternative solution, though.

Maybe we could improve the situation by introducing a check at the end of each test which verifies the queue is empty?


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18923
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I25e10e28de174337233e6a3bb32cc16f2d7d614e
Gerrit-Change-Number: 18923
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 19 Jun 2020 20:12:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200619/4bd7a12c/attachment.htm>


More information about the gerrit-log mailing list