This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18907 ) Change subject: assignment_fsm: fix assignment_count(): conn->lchan may be NULL ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/18907/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/18907/1//COMMIT_MSG@28 PS1, Line 28: Apparently conn->lchan can be NULL, so assignment_count() must be "conn->lchan can become NULL whenever the RSL link is torn down for whichever reason, so..." https://gerrit.osmocom.org/c/osmo-bsc/+/18907/1/src/osmo-bsc/assignment_fsm.c File src/osmo-bsc/assignment_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/18907/1/src/osmo-bsc/assignment_fsm.c@78 PS1, Line 78: struct gsm_bts *bts = conn_get_bts(conn); \ I think I'd rather fix conn_get_bts() to be allowed to return NULL, and visit all callers to handle that situation, either by assert (as before) or by proper error log and so on -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18907 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id681dfb0ad654bdb4b71805d1ad4f39a8bf6bbd1 Gerrit-Change-Number: 18907 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: neels <nhofmeyr at sysmocom.de> Gerrit-Comment-Date: Thu, 18 Jun 2020 15:55:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200618/fd499ed6/attachment.htm>