Change in osmo-mgw[master]: trunk: parse E1 trunk number

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18752 )

Change subject: trunk: parse E1 trunk number
......................................................................


Patch Set 6:

(2 comments)

https://gerrit.osmocom.org/c/osmo-mgw/+/18752/6/src/libosmo-mgcp/mgcp_trunk.c 
File src/libosmo-mgcp/mgcp_trunk.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/18752/6/src/libosmo-mgcp/mgcp_trunk.c@142 
PS6, Line 142: 		trunk_nr = strtoul(epname + prefix_len, &str_trunk_nr_end, 10);
you are missing setting errno = 0 prior to calling it.


https://gerrit.osmocom.org/c/osmo-mgw/+/18752/6/src/libosmo-mgcp/mgcp_trunk.c@143 
PS6, Line 143: 		if (errno == ERANGE || trunk_nr > 64 || trunk_nr == 0
if ((errno == ERANGE && pt == ULONG_MAX) || (errno && !trunk_nr) ||
    (epname + prefix_len) == str_trunk_nr_end) ||
    trunk_nr > 64 || trunk_nr == 0) {
    return NULL;
}

btw is it expected that trunk_nr cannot be 0? for which reason?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18752
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ifdaab953544151e73b58cc3e95d21afdb40765f4
Gerrit-Change-Number: 18752
Gerrit-PatchSet: 6
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 18 Jun 2020 13:55:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200618/7ff90200/attachment.htm>