Change in osmo-bts[master]: Introduce bts_shutdown FSM

[fixeria]

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18903 )

Change subject: Introduce bts_shutdown FSM
......................................................................


Patch Set 1:

(6 comments)

https://gerrit.osmocom.org/c/osmo-bts/+/18903/1/include/osmo-bts/bts_shutdown_fsm.h 
File include/osmo-bts/bts_shutdown_fsm.h:

https://gerrit.osmocom.org/c/osmo-bts/+/18903/1/include/osmo-bts/bts_shutdown_fsm.h@29 
PS1, Line 29: ST_BTS_SHUTDOWN_NONE
Cosmetic: BTS_SHUTDOWN_ST_* and BTS_SHUTDOWN_EV_* is more usual the ST_*. Not critical.


https://gerrit.osmocom.org/c/osmo-bts/+/18903/1/include/osmo-bts/bts_shutdown_fsm.h@41 
PS1, Line 41: bts_shutdown
Rather move this API to bts.{c,h}, so there will be no need to include this header everywhere.


https://gerrit.osmocom.org/c/osmo-bts/+/18903/1/src/common/bts.c 
File src/common/bts.c:

https://gerrit.osmocom.org/c/osmo-bts/+/18903/1/src/common/bts.c@a275 
PS1, Line 275: exit(42);
Horay! Finally we can get rid of this magic return code that confuses systemd...


https://gerrit.osmocom.org/c/osmo-bts/+/18903/1/src/common/bts_shutdown_fsm.c 
File src/common/bts_shutdown_fsm.c:

https://gerrit.osmocom.org/c/osmo-bts/+/18903/1/src/common/bts_shutdown_fsm.c@51 
PS1, Line 51: st_bts_shutdown_wait_ramp_down_compl_on_enter
Given that it's a static (private) symbol, its name can be much shorter. At least there is no need to prefix with 'st_bts_shutdown' because everything in this file is about BTS shutdown, so it looks redundant. Also not critical, but I would still prefer short names.


https://gerrit.osmocom.org/c/osmo-bts/+/18903/1/src/common/bts_shutdown_fsm.c@68 
PS1, Line 68: llist_for_each_entry_reverse
Would be nice to add a comment explaining why we doing reverse here.


https://gerrit.osmocom.org/c/osmo-bts/+/18903/1/src/common/bts_shutdown_fsm.c@130 
PS1, Line 130: constructor
Constructors are usually placed at the bottom of the file.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18903
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I8f48f17e61c3b9b86342eaf5b8a2b1ac9758bde5
Gerrit-Change-Number: 18903
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Thu, 18 Jun 2020 13:37:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200618/cd7108ae/attachment.htm>