Change in osmocom-bb[master]: firmware/apps/rssi: enlarge text buffer in refresh_display()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Jun 18 11:42:04 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/18747 )

Change subject: firmware/apps/rssi: enlarge text buffer in refresh_display()
......................................................................

firmware/apps/rssi: enlarge text buffer in refresh_display()

This change fixes several warnings reported by GCC 10.1.0:

  apps/rssi/main.c:238:30: warning: 'sprintf' may write a terminating
                           nul past the end of the destination
  apps/rssi/main.c:238:4: note: 'sprintf' output between 10 and 17
                          bytes into a destination of size 16

  apps/rssi/main.c:413:26: warning: '.' directive writing 1 byte into
                           a region of size between 0 and 9
  apps/rssi/main.c:413:3: note: 'sprintf' output between 10 and 20
                          bytes into a destination of size 16

Change-Id: I7980727b78f7622d792d82170f73c90ac5770397
---
M src/target/firmware/apps/rssi/main.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/target/firmware/apps/rssi/main.c b/src/target/firmware/apps/rssi/main.c
index e137806..4b33ee3 100644
--- a/src/target/firmware/apps/rssi/main.c
+++ b/src/target/firmware/apps/rssi/main.c
@@ -170,7 +170,7 @@
 
 static void refresh_display(void)
 {
-	char text[16];
+	char text[32];
 	int bat = battery_info.battery_percent;
 
 	fb_clear();

-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/18747
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I7980727b78f7622d792d82170f73c90ac5770397
Gerrit-Change-Number: 18747
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200618/3af22450/attachment.htm>


More information about the gerrit-log mailing list