Change in osmo-mgw[master]: libosmo-mgcp-client: fix use-after-free in mgcp_client_tx()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Wed Jun 17 14:56:46 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18880 )

Change subject: libosmo-mgcp-client: fix use-after-free in mgcp_client_tx()
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-mgw/+/18880/1/src/libosmo-mgcp-client/mgcp_client.c 
File src/libosmo-mgcp-client/mgcp_client.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/18880/1/src/libosmo-mgcp-client/mgcp_client.c@963 
PS1, Line 963: 	llist_del(&pending->entry);
> Shouldn't this be done in mgcp_client_handle_response()?
No, because in other cases the message is already dequeued.
See mgcp_client_response_pending_get().



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18880
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Id94bb93a6b0ea7b7241cf7868112e9bec3e60f0b
Gerrit-Change-Number: 18880
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Jun 2020 14:56:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200617/733c5d90/attachment.htm>


More information about the gerrit-log mailing list