This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18862 ) Change subject: scheduler: Add rate_ctr informing about too low rts-advance ...................................................................... Patch Set 2: (3 comments) https://gerrit.osmocom.org/c/osmo-bts/+/18862/2/src/common/scheduler.c File src/common/scheduler.c: https://gerrit.osmocom.org/c/osmo-bts/+/18862/2/src/common/scheduler.c@570 PS2, Line 570: (ws) https://gerrit.osmocom.org/c/osmo-bts/+/18862/2/src/common/scheduler.c@603 PS2, Line 603: l1ts->ctrs = rate_ctr_group_alloc(trx, &l1sched_ts_ctrg_desc, (trx->nr + 1) * 10 + tn); hmm, so an index + 10 is used to store counters that do not reflect an actual instance's index? can't we somehow logically nest the rate counters as trx N tn M? using 10 (or 100) seems so "human"/"arbitrary" and gut feeling is that it will need refactoring later... https://gerrit.osmocom.org/c/osmo-bts/+/18862/2/src/common/scheduler.c@605 PS2, Line 605: (ws) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18862 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I76c3dd4020c6d74192b03b1d42413ae536da5f05 Gerrit-Change-Number: 18862 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: neels <nhofmeyr at sysmocom.de> Gerrit-Comment-Date: Wed, 17 Jun 2020 13:24:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200617/b0102712/attachment.htm>