This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18765 ) Change subject: MSC pooling: make NRI mappings VTY configurable ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/18765/3/src/osmo-bsc/bsc_vty.c File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/18765/3/src/osmo-bsc/bsc_vty.c@2094 PS3, Line 2094: FIRST [LAST] > I'm not sure if this FIRST / LAST (generic variables that accept any kind of string) is the best her […] I thought allowing hex is a neat idea, because you're dividing a number of MSC across a range of bits. So I thought one would assign 0-0x0ff and 0x100-0x2ff and so on. But of course dividing the range isn't always by a power of two, and writing those back in integer is a quirk. Yet this case is not like common vty range checking because the nri-bitlen is configurable: even if the vty says <0-32767> we will normally have only <0-1023> allowed (nri-bitlen == 10). I'm a bit undecided... what is more clear? nri add <0-32767> <0-32767> NRI_STR "add\n" "First value of NRI range, should be a number within nri-bitlen\n" "Last...\n" or nri add FIRST LAST I notice that the current patch also fails to explain the ranges... ...well, yeah, best remove ambiguity of hex vs decimal, it's a non-feature -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18765 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6c251f2744d7be26fc4ad74adefc96a6a3fe08b0 Gerrit-Change-Number: 18765 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 16 Jun 2020 21:27:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge at osmocom.org> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200616/dd970297/attachment.htm>