Change in osmo-bts[master]: scheduler: Add rate_ctr informing about too low rts-advance

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Tue Jun 16 18:23:49 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18862 )

Change subject: scheduler: Add rate_ctr informing about too low rts-advance
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/c/osmo-bts/+/18862/1/src/common/scheduler.c 
File src/common/scheduler.c:

https://gerrit.osmocom.org/c/osmo-bts/+/18862/1/src/common/scheduler.c@573 
PS1, Line 573: prepared
This sounds confusing. Maybe rather "... arrived too late"?


https://gerrit.osmocom.org/c/osmo-bts/+/18862/1/src/common/scheduler.c@603 
PS1, Line 603: 100
It can be just 10, because a single transceiver cannot have more than 8 timeslots. Not critical.


https://gerrit.osmocom.org/c/osmo-bts/+/18862/1/src/common/scheduler.c@695 
PS1, Line 695: rate_ctr_inc2
Wrong spacing. Please do <<.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18862
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I76c3dd4020c6d74192b03b1d42413ae536da5f05
Gerrit-Change-Number: 18862
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 16 Jun 2020 18:23:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200616/3ea09670/attachment.htm>


More information about the gerrit-log mailing list