Change in osmo-bts[master]: osmo-bts-trx: include BS Power reduction in Downlink bursts

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18834 )

Change subject: osmo-bts-trx: include BS Power reduction in Downlink bursts
......................................................................

osmo-bts-trx: include BS Power reduction in Downlink bursts

For those osmo-bts-trx specific logical channels with a generic
logical channel state associated, let's finally apply the BS Power
reduction (attenuation) value that was received from the BSC.

Change-Id: Ib692ff1a75a80fceccb481839c8514d4b2a547b9
---
M src/common/scheduler.c
M src/osmo-bts-trx/scheduler_trx.c
2 files changed, 5 insertions(+), 2 deletions(-)

Approvals:
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/common/scheduler.c b/src/common/scheduler.c
index b79c83d..ac9085d 100644
--- a/src/common/scheduler.c
+++ b/src/common/scheduler.c
@@ -1190,6 +1190,10 @@
 	if (func(l1t, chan, bid, br) != 0)
 		goto no_data;
 
+	/* BS Power reduction (2 dB steps) per logical channel */
+	if (l1cs->lchan != NULL)
+		br->att = l1cs->lchan->bs_power * 2;
+
 	/* encrypt */
 	if (br->burst_len && l1cs->dl_encr_algo) {
 		ubit_t ks[114];
diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c
index 6996593..d4a38b6 100644
--- a/src/osmo-bts-trx/scheduler_trx.c
+++ b/src/osmo-bts-trx/scheduler_trx.c
@@ -86,10 +86,9 @@
 			_sched_rts(l1t, tn,
 				(fn + plink->u.osmotrx.rts_advance) % GSM_HYPERFRAME);
 
-			/* TODO: Tx attenuation is always 0? */
+			/* All other parameters to be set by _sched_dl_burst() */
 			br = (struct trx_dl_burst_req) {
 				.fn = fn, .tn = tn,
-				.att = 0,
 			};
 
 			/* get burst for FN */

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18834
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ib692ff1a75a80fceccb481839c8514d4b2a547b9
Gerrit-Change-Number: 18834
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200616/dba3bbba/attachment.htm>