This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgHello neels, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/18754 to look at the new patch set (#2). Change subject: endp: move endpoint name generation into mgcp_endp.c ...................................................................... endp: move endpoint name generation into mgcp_endp.c When the trunk allocates its endpoints by using mgcp_endp_alloc() ist passes the name for each endpoint as a parameter. In order to generate the name endpoint specific knowlege is required. This process can be simplified, since all what mgcp_trunk_alloc_endpts() does is calling mgcp_endp_alloc() in a loop in order to generate a consecuitve series of endpoints. The endpoint names are generated from the index of the for loop. When we just pass the index instead of the endpoint name to mgcp_endp_alloc(), then we can greatly simplify the code since all the knowledge about the name generation can go into mgcp_endp.c. The endpoint will name itsself by the trunk properties and the index number we pass with the allocator function. Change-Id: I8dee07f1c63037d1f73113f69c612d1f2703cee5 Related: OS#2659 --- M include/osmocom/mgcp/mgcp_endp.h M src/libosmo-mgcp/mgcp_endp.c M src/libosmo-mgcp/mgcp_trunk.c 3 files changed, 18 insertions(+), 22 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/54/18754/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18754 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I8dee07f1c63037d1f73113f69c612d1f2703cee5 Gerrit-Change-Number: 18754 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200615/bc4efefc/attachment.htm>