Change in osmo-bsc[master]: log: add MSC number to bsc_subscr_conn_fsm id

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Mon Jun 15 02:05:06 UTC 2020


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18768 )

Change subject: log: add MSC number to bsc_subscr_conn_fsm id
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/18768/4/src/osmo-bsc/bsc_subscr_conn_fsm.c 
File src/osmo-bsc/bsc_subscr_conn_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/18768/4/src/osmo-bsc/bsc_subscr_conn_fsm.c@1071 
PS4, Line 1071: 				  conn->sccp.msc->nr,
> Are we sure msc is always non NULL here?
normally it is guaranteed non null, but indeed it seems like i missed some error cases where it might be null



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18768
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Iae232d0616d6c0009e3abe2dcfcb9c51ddfc761e
Gerrit-Change-Number: 18768
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 15 Jun 2020 02:05:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200615/8ec5ddc4/attachment.htm>


More information about the gerrit-log mailing list