This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18590 ) Change subject: trunk: get rid of virt_trunk pointer ...................................................................... Patch Set 11: Code-Review-1 (4 comments) some still unaddressed https://gerrit.osmocom.org/c/osmo-mgw/+/18590/11/src/libosmo-mgcp/mgcp_vty.c File src/libosmo-mgcp/mgcp_vty.c: https://gerrit.osmocom.org/c/osmo-mgw/+/18590/11/src/libosmo-mgcp/mgcp_vty.c@751 PS11, Line 751: OSMO_ASSERT(trunk); thanks for applying here... https://gerrit.osmocom.org/c/osmo-mgw/+/18590/11/src/libosmo-mgcp/mgcp_vty.c@760 PS11, Line 760: struct mgcp_trunk *trunk = mgcp_trunk_by_num(g_cfg, MGCP_VIRT_TRUNK_ID); ...and there are still many more of these below The point being that mgcp_trunk_by_num() does not guarantee to actually find a trunk. The virtual trunk may be expected to be always allocated, but if it isn't for whatever reason, leaving the result unchecked may run into situations that are hard to debug. https://gerrit.osmocom.org/c/osmo-mgw/+/18590/11/src/libosmo-mgcp/mgcp_vty.c@882 PS11, Line 882: continue; please still explain, as in previous comment: - below, I find VTY commands that are only valid for the virtual trunk, yet we're writing them for non-virtual trunks? - how is the virtual trunk written to vty now? To me it seems to make sense to write both kinds here? https://gerrit.osmocom.org/c/osmo-mgw/+/18590/11/tests/mgcp/mgcp_test.c File tests/mgcp/mgcp_test.c: https://gerrit.osmocom.org/c/osmo-mgw/+/18590/11/tests/mgcp/mgcp_test.c@771 PS11, Line 771: trunk = mgcp_trunk_by_num(cfg, MGCP_VIRT_TRUNK_ID); OSMO_ASSERT(trunk), and more below -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18590 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I81934fbd211b225ab7920e78510729c8e22607b3 Gerrit-Change-Number: 18590 Gerrit-PatchSet: 11 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Sun, 14 Jun 2020 11:20:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200614/4c0ddec5/attachment.htm>