Change in osmo-gsm-tester[master]: rfemu: add max attenuation getter

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

srs_andre gerrit-no-reply at lists.osmocom.org
Fri Jun 12 13:11:06 UTC 2020


srs_andre has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18791 )


Change subject: rfemu: add max attenuation getter
......................................................................

rfemu: add max attenuation getter

this allows to query the maximum channel attenuation from within a test case

Change-Id: I35f7cb188790c59bbf2450f78c663fbc9440e406
---
M src/osmo_gsm_tester/obj/rfemu.py
M src/osmo_gsm_tester/obj/rfemu_amarisoftctrl.py
M src/osmo_gsm_tester/obj/rfemu_minicircuits.py
3 files changed, 11 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/91/18791/1

diff --git a/src/osmo_gsm_tester/obj/rfemu.py b/src/osmo_gsm_tester/obj/rfemu.py
index b2add6b..ac34ee1 100644
--- a/src/osmo_gsm_tester/obj/rfemu.py
+++ b/src/osmo_gsm_tester/obj/rfemu.py
@@ -39,6 +39,11 @@
         """Set attenuation in dB on the configured channel"""
         pass
 
+    @abstractmethod
+    def get_max_attenuation(self):
+        """Get maximum channel attenuation"""
+        pass
+
 def get_instance_by_type(rfemu_type, rfemu_opt):
     """Allocate a RFemulation child class based on type. Opts are passed to the newly created object."""
     if rfemu_type == 'amarisoftctl':
diff --git a/src/osmo_gsm_tester/obj/rfemu_amarisoftctrl.py b/src/osmo_gsm_tester/obj/rfemu_amarisoftctrl.py
index 6ef25bb..17aa43a 100644
--- a/src/osmo_gsm_tester/obj/rfemu_amarisoftctrl.py
+++ b/src/osmo_gsm_tester/obj/rfemu_amarisoftctrl.py
@@ -59,5 +59,7 @@
         result = self.ws.recv()
         self.dbg('Received CTRL msg: "%s"' % result)
 
+    def get_max_attenuation(self):
+        return 200 # maximum cell_gain value in Amarisoft
 
 # vim: expandtab tabstop=4 shiftwidth=4
diff --git a/src/osmo_gsm_tester/obj/rfemu_minicircuits.py b/src/osmo_gsm_tester/obj/rfemu_minicircuits.py
index eea3a0e..6214040 100644
--- a/src/osmo_gsm_tester/obj/rfemu_minicircuits.py
+++ b/src/osmo_gsm_tester/obj/rfemu_minicircuits.py
@@ -64,4 +64,8 @@
         self.dbg('Received response: "%s"' % data_str)
         if data_str != '1':
             raise log.Error('Mini-circuits attenuation device returned failure! %s' & data_str)
+
+    def get_max_attenuation(self):
+        return 95 # Maximum value of the Mini-Circuits RC4DAT-6G-95
+
 # vim: expandtab tabstop=4 shiftwidth=4

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18791
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I35f7cb188790c59bbf2450f78c663fbc9440e406
Gerrit-Change-Number: 18791
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre <andre at softwareradiosystems.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200612/2f3753b4/attachment.htm>


More information about the gerrit-log mailing list