This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18761 ) Change subject: RSL_Emulation: fix rx of tr_RSL_PAGING_CMD() ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18761/1/library/RSL_Emulation.ttcn File library/RSL_Emulation.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18761/1/library/RSL_Emulation.ttcn@551 PS1, Line 551: if (ispresent(ConnectionTable[i].comp_ref) and ConnectionTable[i].comp_ref != null) { Is this ispresent() really needed? I think they may have been an error here and the same thing you are checking was aimed to be checked before. So you can probably drop the ispresent ? (or otherwise assign := omit to it where needed). -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18761 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iaf7730153a3a19e448a33298c3e12212a55929d5 Gerrit-Change-Number: 18761 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 11 Jun 2020 11:44:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200611/b6d39bab/attachment.htm>