Change in osmo-msc[master]: msc_ho: fix CALL IDENTIFIER in HANDOVER REQUEST

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Tue Jun 9 14:36:20 UTC 2020


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/18740 )

Change subject: msc_ho: fix CALL IDENTIFIER in HANDOVER REQUEST
......................................................................


Patch Set 3:

(1 comment)

(ensur all messages are sent)

https://gerrit.osmocom.org/c/osmo-msc/+/18740/2/src/libmsc/msc_ho.c 
File src/libmsc/msc_ho.c:

https://gerrit.osmocom.org/c/osmo-msc/+/18740/2/src/libmsc/msc_ho.c@406 
PS2, Line 406: 			.call_id = cc_trans->callref,
> NO . […]
Thats indeed not required. The generator function unconditionally picks it, which is ok. The struct member is only used when the MSC receives messages and decodes them.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/18740
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I6b1b55b3f5a3092d9557dc2512020c766a9ff744
Gerrit-Change-Number: 18740
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 09 Jun 2020 14:36:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200609/ae768b10/attachment.htm>


More information about the gerrit-log mailing list