This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/18723 ) Change subject: UHDDevice: Compute TxGain on UHD API based on expected Tx output power ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-trx/+/18723/2/Transceiver52M/device/uhd/UHDDevice.cpp File Transceiver52M/device/uhd/UHDDevice.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/18723/2/Transceiver52M/device/uhd/UHDDevice.cpp@216 PS2, Line 216: tx_gain_db > if you subtract something from gain, then it is attenuation. […] AFAIU power attenuation is what you subtract from power to attenuate it, giving a lower power (attenuated power). So here I'm basically first getting an attenuation by getting the difference between 2 gain values (as in how much do you need to attenuate the nominal UHD Tx Gain to get to the required UHD gain): att = (desc.nom_uhd_tx_gain - tx_gain_db) Then I'm simply applying that attenuation to get nominal output Tx power (assuming slope is 1:1 with UHD tx Gain values here), by which I get and return an attenuated power: return desc.nom_out_tx_power - att; I'm happy to change any terminology you feel it's more clear. That's what I'm also trying to do in this commit by also decoupling UHD Tx Gain (internal/implementation specific to the radiODevice class) and the real output power (the one the upper layers are interested in). -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/18723 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I6f432465dce5c6ec1f1bc4653f6149efb18c3f43 Gerrit-Change-Number: 18723 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Tue, 09 Jun 2020 09:51:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge at osmocom.org> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200609/e2a291fc/attachment.htm>