This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/18731 ) Change subject: e1_input: Initialize list struct ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/libosmo-abis/+/18731/2/src/e1_input.c File src/e1_input.c: https://gerrit.osmocom.org/c/libosmo-abis/+/18731/2/src/e1_input.c@571 PS2, Line 571: talloc_zero > If we were not using zero-initialization everywhere, we would notice this problem much earlier. In general I agree, but not in this specific case. Zero-initializing all llist_heads by talloc_zero of the entire struct makes sure that anyone performing an illegal operation on the llist_head (such as adding something) will cause a null pointer dereference rather than dereferencing some random part of memory (which might be valid! [unlikely, but still]) -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/18731 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I850fdc43d597267aa66c6975aca9c1753231ac65 Gerrit-Change-Number: 18731 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Tue, 09 Jun 2020 07:35:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200609/09b0fa18/attachment.htm>