Change in osmo-e1-recorder[master]: fix "-Werror" build against latest libosmo-abis

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Jun 9 07:13:07 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/18735 )

Change subject: fix "-Werror" build against latest libosmo-abis
......................................................................

fix "-Werror" build against latest libosmo-abis

libosmo-abisrecently marked the 'out_cb' of the subchan_demux
as 'const', which caused compiler warnings/errors.

Related: libosmo-abis.git Ia082b9fddf03d02afd007825a1588a3ef0dbedae
Change-Id: I0cf430980e50fa8094f0efc7642004fb5923c4c6
---
M src/e1cap_dump.c
M src/flip_bits.c
M src/flip_bits.h
3 files changed, 8 insertions(+), 8 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/e1cap_dump.c b/src/e1cap_dump.c
index bcb4916..4cc8538 100644
--- a/src/e1cap_dump.c
+++ b/src/e1cap_dump.c
@@ -153,11 +153,12 @@
 }
 
 
-static void handle_data(struct osmo_e1cap_pkthdr *pkt, uint8_t *data, int len)
+static void handle_data(struct osmo_e1cap_pkthdr *pkt, const uint8_t *idata, int len)
 {
+	uint8_t data[len];
 	struct timeval tv;
 
-	flip_buf_bits(data, len);
+	flip_buf_bits(data, idata, len);
 #if 0
 	/* filter out all-ff/all-fe/all-7f */
 	if (all_bytes_are(0xff, data, len) ||
@@ -193,7 +194,7 @@
 	}
 }
 
-static int subch_demux_out_cb(struct subch_demux *dmx, int ch, uint8_t *data,
+static int subch_demux_out_cb(struct subch_demux *dmx, int ch, const ubit_t *data,
 			      int len, void *c)
 {
 	OSMO_ASSERT(ch == g_filter_subslot);
diff --git a/src/flip_bits.c b/src/flip_bits.c
index f33994e..6b382ed 100644
--- a/src/flip_bits.c
+++ b/src/flip_bits.c
@@ -16,14 +16,13 @@
         }
 }
 
-uint8_t *flip_buf_bits(uint8_t *buf, int len)
+uint8_t *flip_buf_bits(uint8_t *out, const uint8_t *in, int len)
 {
         int i;
-        uint8_t *start = buf;
 
         for (i = 0 ; i < len; i++) {
-                buf[i] = flip_table[(uint8_t)buf[i]];
+                out[i] = flip_table[(uint8_t)in[i]];
         }
 
-        return start;
+        return out;
 }
diff --git a/src/flip_bits.h b/src/flip_bits.h
index 319a181..249e45b 100644
--- a/src/flip_bits.h
+++ b/src/flip_bits.h
@@ -1,4 +1,4 @@
 #pragma once
 
 void init_flip_bits(void);
-uint8_t *flip_buf_bits(uint8_t * buf , int len);
+uint8_t *flip_buf_bits(uint8_t *out, const uint8_t *in, int len);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-e1-recorder/+/18735
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-e1-recorder
Gerrit-Branch: master
Gerrit-Change-Id: I0cf430980e50fa8094f0efc7642004fb5923c4c6
Gerrit-Change-Number: 18735
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200609/f4e135f1/attachment.htm>


More information about the gerrit-log mailing list