Change in libosmocore[master]: lapd/lapdm: print user-defined string name instead of (dl=%p)

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Sun Jun 7 20:18:25 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18002 )

Change subject: lapd/lapdm: print user-defined string name instead of (dl=%p)
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/18002/6/src/gsm/lapdm.c 
File src/gsm/lapdm.c:

https://gerrit.osmocom.org/c/libosmocore/+/18002/6/src/gsm/lapdm.c@273 
PS6, Line 273: 		lc->name = talloc_strdup(lc, name_pfx);
don't you need to free here if lc->name is already set? Because you are not allocating lc here.
osmo_talloc_replace_string



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18002
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ie6742843fff809edffcac24c4dce4edf66bc71be
Gerrit-Change-Number: 18002
Gerrit-PatchSet: 6
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sun, 07 Jun 2020 20:18:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200607/83e6ed0e/attachment.htm>


More information about the gerrit-log mailing list