This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/18708 ) Change subject: scheduler: fix trx_sched_set_lchan(): send TRXC HANDOVER ...................................................................... scheduler: fix trx_sched_set_lchan(): send TRXC HANDOVER The purpose of TRXC [NO]HANDOVER commands is to control handover detection in transceiver. By default, handover detection is enabled on all inactive channels. As soon as the BSC activates a logical channel, osmo-bts-trx needs to send TRXC NOHANDOVER to the transceiver, so handover detection is disabled for that channel. As soon as a logical channel is deactivated, osmo-bts-trx needs to send TRXC HANDOVER to the transceiver, so handover detection is activated again. As it turns out, osmo-bts-trx never sends TRXC HANDOVER command to the transceiver. Instead, TRXC NOHANDOVER is being sent twice. The culprit is trx_sched_set_lchan(): for some reason it sends TRXC NOHANDOVER on channel deactivation, while it's supposed to send TRXC HANDOVER instead. Let's fix this. Interestingly enough, in some rare cases this bug triggers another bug (see OS#4586), causing a memory leak in trx_ctrl_cmd_cb(). Change-Id: Ia106baafc1b7fafb36f11ca378a285d71d1df5a3 Related: OS#4592, OS#4586 --- M src/common/scheduler.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/08/18708/1 diff --git a/src/common/scheduler.c b/src/common/scheduler.c index 5b398d1..bdd5387 100644 --- a/src/common/scheduler.c +++ b/src/common/scheduler.c @@ -1003,9 +1003,9 @@ } } - /* disable handover detection (on deactivation) */ + /* enable handover detection on deactivation */ if (!active) - _sched_act_rach_det(l1t, tn, ss, 0); + _sched_act_rach_det(l1t, tn, ss, 1); return rc; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18708 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia106baafc1b7fafb36f11ca378a285d71d1df5a3 Gerrit-Change-Number: 18708 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200607/7338edf2/attachment.htm>