This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/18692 ) Change subject: msc_a: add callref as call id to ASSIGNMENT REQ. ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/osmo-msc/+/18692/1/src/libmsc/msc_a.c File src/libmsc/msc_a.c: https://gerrit.osmocom.org/c/osmo-msc/+/18692/1/src/libmsc/msc_a.c@544 PS1, Line 544: call_id_present = true, : .call_id = cc_trans->callref you are adding it unconditionally here. If we only support AoIP, we can do this unconditionally. Should we still support SCCPlite (I know we do in the BSC, but do we in the MSC?), we would have to add call_id only in AoIP situations. https://gerrit.osmocom.org/c/osmo-msc/+/18692/1/src/libmsc/ran_msg_a.c File src/libmsc/ran_msg_a.c: https://gerrit.osmocom.org/c/osmo-msc/+/18692/1/src/libmsc/ran_msg_a.c@1000 PS1, Line 1000: if(ac->call_id_present) if if was a function... (sorry) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/18692 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I4288f47e4a6d61ec672f431723f6e72c7c6b0799 Gerrit-Change-Number: 18692 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Fri, 05 Jun 2020 16:21:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200605/dbafd76c/attachment.htm>