This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18680 ) Change subject: rsl: refactor handling of RSL_IE_MR_CONFIG ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/18680/1/src/common/amr.c File src/common/amr.c: https://gerrit.osmocom.org/c/osmo-bts/+/18680/1/src/common/amr.c@135 PS1, Line 135: amr_mrc->bts_mode[2].threshold = > So if len = 4, we still reach here, and access offset 5. […] I see the point now, thanks! I also just noticed that this functions already has some length checks (see lines 101 .. 111), so we only need to make sure that at least two bytes present. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18680 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ibfd5845ea429945b352dd14421e86562998d65ca Gerrit-Change-Number: 18680 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 05 Jun 2020 11:37:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200605/ff3bed0f/attachment.htm>