Change in osmo-bsc[master]: refactor bsc_find_msc()'s round-robin

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Jun 4 11:18:20 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18505 )

Change subject: refactor bsc_find_msc()'s round-robin
......................................................................


Patch Set 4: Code-Review+1

> please read my very elaborate response to that, it is reasoned about both in the commit log and in the response to your initial question.

I don't agree with your point about using a number instead of a pointer because it's "safer". If that was the case, then we'd be dropping lots of pointers everywhere and using c++ with references or other programming language.
That being said, I'm not going to block this patch, so +1.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18505
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Idf71f07ba5a17d5b870dc1a5a2875b6fedb61291
Gerrit-Change-Number: 18505
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Thu, 04 Jun 2020 11:18:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200604/a8449e8f/attachment.htm>


More information about the gerrit-log mailing list