Change in osmo-hlr[master]: osmo-mslookup-client: fix segfault for respond_error() caller

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Wed Jun 3 17:17:37 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/18651 )

Change subject: osmo-mslookup-client: fix segfault for respond_error() caller
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-hlr/+/18651/1/src/mslookup/osmo-mslookup-client.c 
File src/mslookup/osmo-mslookup-client.c:

https://gerrit.osmocom.org/c/osmo-hlr/+/18651/1/src/mslookup/osmo-mslookup-client.c@587 
PS1, Line 587: 			if (!r || r->last)
would be nice documenting this behavior (like r=NULL being passed by error.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/18651
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I1acb0b8aa00c098d1f1f1cc17035daa38ce29fd3
Gerrit-Change-Number: 18651
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 03 Jun 2020 17:17:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200603/fd4a6769/attachment.htm>


More information about the gerrit-log mailing list