Change in osmo-ttcn3-hacks[master]: MGCP_Test: fix test vector in TC_amr_oa_bwe_rtp_conversion

[dexter]

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18450 )

Change subject: MGCP_Test: fix test vector in TC_amr_oa_bwe_rtp_conversion
......................................................................

MGCP_Test: fix test vector in TC_amr_oa_bwe_rtp_conversion

The rtp payload test vector in TC_amr_oa_bwe_rtp_conversion is wrong, it
lacks the last byte which should be 0x00. Also the testvector is not
very well chossen since it after BWE conversion the actual payload does
not shrink (even if it looks like if it would because of the 0x00 byte
at the end). Lets pick a better payload from a real world trace that
actually shrinks by one byte when it is converted to BWE and use that
one.

Change-Id: Id4256049bbca49ad5c2eb0579128838ebae062f8
---
M mgw/MGCP_Test.ttcn
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved



diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn
index 0de5308..be4e634 100644
--- a/mgw/MGCP_Test.ttcn
+++ b/mgw/MGCP_Test.ttcn
@@ -2082,8 +2082,12 @@
 		setverdict(pass);
 	}
 
+	/* Note: The hexstrings used with the f_TC_amr_x_x_rtp_conversion test
+	 * functions are real world AMR RTP payloads including AMR header. The
+	 * payloads were extracted from a trace with known good payloads. */
+
 	testcase TC_amr_oa_bwe_rtp_conversion() runs on dummy_CT {
-		 f_TC_amr_x_x_rtp_conversion('100c4e9ba850e30d5d53d04de41e7c'O, '10d3a6ea1438c35754f41379079f'O, "octet-align=1", "octet-align=0");
+		f_TC_amr_x_x_rtp_conversion('2014e959f35fdfe5e9667ffbc088818088'O, '217a567cd7f7f97a599ffef022206022'O, "octet-align=1", "octet-align=0");
 	}
 
 	testcase TC_amr_oa_oa_rtp_conversion() runs on dummy_CT {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18450
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id4256049bbca49ad5c2eb0579128838ebae062f8
Gerrit-Change-Number: 18450
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200602/ab8a0706/attachment.htm>