Change in libosmocore[master]: bts_features: fix: properly check the result of bitvec_get_bit_pos()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Tue Jun 2 10:17:32 UTC 2020


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18619 )

Change subject: bts_features: fix: properly check the result of bitvec_get_bit_pos()
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/18619/2/include/osmocom/gsm/bts_features.h 
File include/osmocom/gsm/bts_features.h:

https://gerrit.osmocom.org/c/libosmocore/+/18619/2/include/osmocom/gsm/bts_features.h@43 
PS2, Line 43: 	return bitvec_get_bit_pos(features, feature) == ONE;
> shouldn't we better assert() in this case?
I don't think so. Imagine you're running an old version of osmo-bsc and the recent version of osmo-bts that has some new features (and thus sends a longer feature vector). We don't want to crash the whole BSC just because of that, right?



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18619
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id1ad92e7654a806bb920ae9507c88a122e8d09f0
Gerrit-Change-Number: 18619
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 02 Jun 2020 10:17:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200602/4d7b289c/attachment.htm>


More information about the gerrit-log mailing list