Change in osmo-mgw[master]: libosmo-mgcp-client: mgcp_client_tx(): return rc on error

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Jul 31 10:21:50 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/19293 )

Change subject: libosmo-mgcp-client: mgcp_client_tx(): return rc on error
......................................................................

libosmo-mgcp-client: mgcp_client_tx(): return rc on error

Change-Id: Ic2080241ceb9e00109a5222b78c35b7971320c21
---
M src/libosmo-mgcp-client/mgcp_client.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  daniel: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libosmo-mgcp-client/mgcp_client.c b/src/libosmo-mgcp-client/mgcp_client.c
index ffba074..b1909f0 100644
--- a/src/libosmo-mgcp-client/mgcp_client.c
+++ b/src/libosmo-mgcp-client/mgcp_client.c
@@ -1027,12 +1027,12 @@
 
 mgcp_tx_error:
 	if (!pending)
-		return -1;
+		return rc;
 	/* Dequeue pending response, it's going to be free()d */
 	llist_del(&pending->entry);
 	/* Pass NULL to response cb to indicate an error */
 	mgcp_client_handle_response(mgcp, pending, NULL);
-	return -1;
+	return rc;
 }
 
 /*! Cancel a pending transaction.

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/19293
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ic2080241ceb9e00109a5222b78c35b7971320c21
Gerrit-Change-Number: 19293
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200731/f096ff22/attachment.htm>


More information about the gerrit-log mailing list