Change in osmo-ttcn3-hacks[master]: bsc CBSP: log expected response in f_cbsp_write

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Thu Jul 30 14:31:27 UTC 2020


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19433 )

Change subject: bsc CBSP: log expected response in f_cbsp_write
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> doesnt the MATCH log category print that kind of information? I would generally prefer us not to add hand-written log statements if the same can be achieved by changing the TITAN logger configuriation for this component to include matching information.

For me it is super handy to have one specific string to search for in the log output that directly shows me what message is expected at that precise line in the test.
I am aware that the matching and mismatching is shown in the logging, but with that alone I find it hard to find the expected message I am looking for...
The purpose of this log message is basically served when the problem is fixed, so I'm also fine with not merging it.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19433
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I844717b0f665496a842764b3b915ba64249cd617
Gerrit-Change-Number: 19433
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 30 Jul 2020 14:31:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200730/d6df36c9/attachment.htm>


More information about the gerrit-log mailing list