Change in osmo-bsc[master]: acc.c: Don't use C99 constructs, this breaks builds on Debian 8

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Jul 30 11:32:59 UTC 2020


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/19455 )

Change subject: acc.c: Don't use C99 constructs, this breaks builds on Debian 8
......................................................................

acc.c: Don't use C99 constructs, this breaks builds on Debian 8

[  160s] acc.c: In function 'get_highest_allowed_acc':
[  160s] acc.c:117:2: error: 'for' loop initial declarations are only allowed in C99 or C11 mode
[  160s]   for (int i = 9; i >= 0; i--) {
[  160s]   ^
[  160s] acc.c:117:2: note: use option -std=c99, -std=gnu99, -std=c11 or -std=gnu11 to compile your code
[  160s] acc.c: In function 'get_lowest_allowed_acc':
[  160s] acc.c:127:2: error: 'for' loop initial declarations are only allowed in C99 or C11 mode
[  160s]   for (int i = 0; i < 10; i++) {
[  160s]   ^
[  160s] Makefile:617: recipe for target 'acc.o' failed

Change-Id: I03722854634b2d6d6f1abac7c7553762b5fc6890
---
M src/osmo-bsc/acc.c
1 file changed, 6 insertions(+), 2 deletions(-)

Approvals:
  pespin: Looks good to me, approved; Verified
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/acc.c b/src/osmo-bsc/acc.c
index b25f2fd..72b4591 100644
--- a/src/osmo-bsc/acc.c
+++ b/src/osmo-bsc/acc.c
@@ -114,7 +114,9 @@
 
 static uint8_t get_highest_allowed_acc(uint16_t mask)
 {
-	for (int i = 9; i >= 0; i--) {
+	int i;
+
+	for (i = 9; i >= 0; i--) {
 		if (mask & (1 << i))
 			return i;
 	}
@@ -124,7 +126,9 @@
 
 static uint8_t get_lowest_allowed_acc(uint16_t mask)
 {
-	for (int i = 0; i < 10; i++) {
+	int i;
+
+	for (i = 0; i < 10; i++) {
 		if (mask & (1 << i))
 			return i;
 	}

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/19455
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I03722854634b2d6d6f1abac7c7553762b5fc6890
Gerrit-Change-Number: 19455
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Assignee: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200730/626e7820/attachment.htm>


More information about the gerrit-log mailing list