This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19381 ) Change subject: i460_mux: correctly reset subchannels ...................................................................... Patch Set 2: (1 comment) (send messages) https://gerrit.osmocom.org/c/libosmocore/+/19381/1/src/gsm/i460_mux.c File src/gsm/i460_mux.c: https://gerrit.osmocom.org/c/libosmocore/+/19381/1/src/gsm/i460_mux.c@361 PS1, Line 361: schan->rate = OSMO_I460_RATE_NONE; > to be honest, in indsight, I don't even understand why we memset the entire sub-channel here. […] the alloc_bitbuf() is not a problem, schan->demux.out_bitbuf is freed, so there is no leak here. However, the tx_queue is indeed problematic. Also line 348 introduces a crash on the next use of the subchannel when the alloc_bitbuf() has failed in the last call. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19381 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I937a9d4db95f44a860cd2c5dbb660dc1970b9a49 Gerrit-Change-Number: 19381 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 29 Jul 2020 20:34:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge at osmocom.org> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200729/928bc0c5/attachment.htm>