Change in libosmo-sccp[master]: SCOC: log message type that was received for unknown local reference

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Wed Jul 29 20:01:21 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/19447 )

Change subject: SCOC: log message type that was received for unknown local reference
......................................................................

SCOC: log message type that was received for unknown local reference

A message like
DLSCCP <0011> sccp_scoc.c:1653 Cannot find connection for local reference 1154
is not incredibly useful, as you don't even know what type of SCCP/SUA
message had been received.

Change-Id: I18af9d7e9ea4877b13bf98a980b0ba97c5ed6599
---
M src/sccp_scoc.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/sccp_scoc.c b/src/sccp_scoc.c
index 015850e..1ce08f8 100644
--- a/src/sccp_scoc.c
+++ b/src/sccp_scoc.c
@@ -1649,8 +1649,8 @@
 		conn_id = xua_msg_get_u32(xua, SUA_IEI_DEST_REF);
 		conn = conn_find_by_id(inst, conn_id);
 		if (!conn) {
-			LOGP(DLSCCP, LOGL_NOTICE, "Cannot find connection for "
-			     "local reference %u\n", conn_id);
+			LOGP(DLSCCP, LOGL_NOTICE, "Received %s: Cannot find connection for "
+			     "local reference %u\n", xua_hdr_dump(xua, &xua_dialect_sua), conn_id);
 			sccp_scoc_rx_unass_local_ref(inst, xua);
 			return;
 		}

-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/19447
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I18af9d7e9ea4877b13bf98a980b0ba97c5ed6599
Gerrit-Change-Number: 19447
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200729/9780e0d0/attachment.htm>


More information about the gerrit-log mailing list