Change in libosmocore[master]: vty: Allow using hex and octal representations in cmd numeric ranges

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Wed Jul 29 19:55:17 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19422 )

Change subject: vty: Allow using hex and octal representations in cmd numeric ranges
......................................................................


Patch Set 2: Code-Review-1

> I am using this to define <0x00-0xffffffffff> cpu-affinity masks, to store them that way upon show running-config and then to allow to set cpu-affinity-masks also as hex, which is a lot more comfortable.

I'm sorry, but I really don't like hex numeric ranges in the VTY syntax.  It is a strong deviation of anything I've seen in Cisco, and also particularly from the quagga/zebra VTY that we inherit.

If nobody else of the reviewers has any issues, I am happy to defer to the majority.  I'd prefer not to touch the VTY numeric range code and work without hex-masks but by specifying indivudal CPU IDs or CPU ID ranges, ...


-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19422
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia2b7fbbf5502c28374c21dbff548232680da27d4
Gerrit-Change-Number: 19422
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 29 Jul 2020 19:55:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200729/e311f4b7/attachment.htm>


More information about the gerrit-log mailing list